Discussion:
[PATCH] libsepol: Export sepol_polcap_getnum/name functions
Stephen Smalley
2018-03-08 20:19:26 UTC
Permalink
Export the sepol_polcap_getnum/name() functions to users of
the shared library. This will enable SETools to stop depending
on the static library.

Note that we may want to move polcaps.h up one level since
the convention is that headers directly under include/sepol are
shared library APIs while headers under include/sepol/policydb
are limited to static users. However, this will unnecessarily
break the build for existing static users so it is deferred.

Suggested-by: Chris PeBenito <***@ieee.org>
Signed-off-by: Stephen Smalley <***@tycho.nsa.gov>
---
libsepol/src/libsepol.map.in | 2 ++
1 file changed, 2 insertions(+)

diff --git a/libsepol/src/libsepol.map.in b/libsepol/src/libsepol.map.in
index 2a9996f7..d879016c 100644
--- a/libsepol/src/libsepol.map.in
+++ b/libsepol/src/libsepol.map.in
@@ -56,4 +56,6 @@ LIBSEPOL_1.1 {
sepol_module_policydb_to_cil;
sepol_kernel_policydb_to_cil;
sepol_kernel_policydb_to_conf;
+ sepol_polcap_getnum;
+ sepol_polcap_getname;
} LIBSEPOL_1.0;
--
2.14.3
jwcart2
2018-03-15 18:01:03 UTC
Permalink
Post by Stephen Smalley
Export the sepol_polcap_getnum/name() functions to users of
the shared library. This will enable SETools to stop depending
on the static library.
Note that we may want to move polcaps.h up one level since
the convention is that headers directly under include/sepol are
shared library APIs while headers under include/sepol/policydb
are limited to static users. However, this will unnecessarily
break the build for existing static users so it is deferred.
---
libsepol/src/libsepol.map.in | 2 ++
1 file changed, 2 insertions(+)
diff --git a/libsepol/src/libsepol.map.in b/libsepol/src/libsepol.map.in
index 2a9996f7..d879016c 100644
--- a/libsepol/src/libsepol.map.in
+++ b/libsepol/src/libsepol.map.in
@@ -56,4 +56,6 @@ LIBSEPOL_1.1 {
sepol_module_policydb_to_cil;
sepol_kernel_policydb_to_cil;
sepol_kernel_policydb_to_conf;
+ sepol_polcap_getnum;
+ sepol_polcap_getname;
} LIBSEPOL_1.0;
--
James Carter <***@tycho.nsa.gov>
National Security Agency
William Roberts
2018-03-15 18:31:47 UTC
Permalink
Post by Stephen Smalley
Export the sepol_polcap_getnum/name() functions to users of
the shared library. This will enable SETools to stop depending
on the static library.
Note that we may want to move polcaps.h up one level since
the convention is that headers directly under include/sepol are
shared library APIs while headers under include/sepol/policydb
are limited to static users. However, this will unnecessarily
break the build for existing static users so it is deferred.
---
libsepol/src/libsepol.map.in | 2 ++
1 file changed, 2 insertions(+)
diff --git a/libsepol/src/libsepol.map.in b/libsepol/src/libsepol.map.in
index 2a9996f7..d879016c 100644
--- a/libsepol/src/libsepol.map.in
+++ b/libsepol/src/libsepol.map.in
@@ -56,4 +56,6 @@ LIBSEPOL_1.1 {
sepol_module_policydb_to_cil;
sepol_kernel_policydb_to_cil;
sepol_kernel_policydb_to_conf;
+ sepol_polcap_getnum;
+ sepol_polcap_getname;
} LIBSEPOL_1.0;
Acked-by: William Roberts <***@intel.com>
William Roberts
2018-03-15 20:53:08 UTC
Permalink
merged:
https://github.com/SELinuxProject/selinux/pull/85


On Thu, Mar 15, 2018 at 11:31 AM, William Roberts
Post by Stephen Smalley
Export the sepol_polcap_getnum/name() functions to users of
the shared library. This will enable SETools to stop depending
on the static library.
Note that we may want to move polcaps.h up one level since
the convention is that headers directly under include/sepol are
shared library APIs while headers under include/sepol/policydb
are limited to static users. However, this will unnecessarily
break the build for existing static users so it is deferred.
---
libsepol/src/libsepol.map.in | 2 ++
1 file changed, 2 insertions(+)
diff --git a/libsepol/src/libsepol.map.in b/libsepol/src/libsepol.map.in
index 2a9996f7..d879016c 100644
--- a/libsepol/src/libsepol.map.in
+++ b/libsepol/src/libsepol.map.in
@@ -56,4 +56,6 @@ LIBSEPOL_1.1 {
sepol_module_policydb_to_cil;
sepol_kernel_policydb_to_cil;
sepol_kernel_policydb_to_conf;
+ sepol_polcap_getnum;
+ sepol_polcap_getname;
} LIBSEPOL_1.0;
Loading...