Discussion:
[PATCH] selinux: remove redundant assignment to len
Colin King
2017-10-14 15:00:49 UTC
Permalink
From: Colin Ian King <***@canonical.com>

The variable len is being set to zero and this value is never
being read since len is being set to a different value just
a few lines later. Remove this redundant assignment. Cleans
up clang warning: Value stored to 'len' is never read

Signed-off-by: Colin Ian King <***@canonical.com>
---
security/selinux/ss/conditional.c | 1 -
1 file changed, 1 deletion(-)

diff --git a/security/selinux/ss/conditional.c b/security/selinux/ss/conditional.c
index 771c96afe1d5..c91543a617ac 100644
--- a/security/selinux/ss/conditional.c
+++ b/security/selinux/ss/conditional.c
@@ -361,7 +361,6 @@ static int cond_read_av_list(struct policydb *p, void *fp, struct cond_av_list *

*ret_list = NULL;

- len = 0;
rc = next_entry(buf, fp, sizeof(u32));
if (rc)
return rc;
--
2.14.1
Paul Moore
2017-10-16 22:37:54 UTC
Permalink
Post by Colin King
The variable len is being set to zero and this value is never
being read since len is being set to a different value just
a few lines later. Remove this redundant assignment. Cleans
up clang warning: Value stored to 'len' is never read
---
security/selinux/ss/conditional.c | 1 -
1 file changed, 1 deletion(-)
Merged.
Post by Colin King
diff --git a/security/selinux/ss/conditional.c b/security/selinux/ss/conditional.c
index 771c96afe1d5..c91543a617ac 100644
--- a/security/selinux/ss/conditional.c
+++ b/security/selinux/ss/conditional.c
@@ -361,7 +361,6 @@ static int cond_read_av_list(struct policydb *p, void *fp, struct cond_av_list *
*ret_list = NULL;
- len = 0;
rc = next_entry(buf, fp, sizeof(u32));
if (rc)
return rc;
--
2.14.1
--
paul moore
www.paul-moore.com
Loading...